[m-dev.] for review: deforestation [3/3]

[Fergus Henderson]

On 24-Apr-1998, Simon Taylor <stayl at cs.mu.OZ.AU> wrote:
> > 
> > > --- pd_info.m	Tue Mar 24 14:52:55 1998
> > > +++ ../compiler/pd_info.m	Mon Mar 30 12:43:00 1998
> > ...
> > > +	% unfold_info contains data used while processing a goal.
> > >  :- type unfold_info
> > >  	--->	unfold_info(
> > >  			proc_info,
> > ...
> > 
> > Used by what?  What sort of processing?
> > 
> > Would "procedure body" be more appropriate than "goal"?
> 
> How about 
>         % unfold_info contains information used while searching a procedure
>         % body for unfolding and deforestation opportunities.

Fine.

> > >  			local_term_info,% local termination info
> > 
> > Local to what -- the subgoal? the procedure?
> 
>                         local_term_info,% information used to prevent 
>                                         % infinite unfolding within the 
>                                         % current procedure.

Fine.

> > 
> > > +	% Find the best matching version for a goal.
> > >  :- pred pd_info__search_version(hlds_goal::in, maybe_version::out,
> > >  	pd_info::pd_info_di, pd_info::pd_info_uo) is det.
> > 
> > Best version of what?
> > 
> 	
>         % Find the deforestation procedure which most closely
>         % matches the given goal.

Fine.

-- 
Fergus Henderson <fjh at cs.mu.oz.au>  |  "I have always known that the pursuit
WWW: <http://www.cs.mu.oz.au/~fjh>  |  of excellence is a lethal habit"
PGP: finger fjh at 128.250.37.3        |     -- the last words of T. S. Garp.