[m-dev.] diff: type_name for higher order, round 2

Fergus Henderson fjh at cs.mu.oz.au
Wed Jul 16 18:56:19 AEST 1997


Tyson Richard DOWD, you wrote:
> 
> +		/* 
> +		** The arg_pseudo_type_info might be a polymorphic variable,
> +		** is so - substitute.
> +		*/

s/is so/if so/

> +        if (MR_BASE_TYPEINFO_IS_HO_PRED(base_type_info) ||
> +                        MR_BASE_TYPEINFO_IS_HO_FUNC(base_type_info)) {

A `MR_BASE_TYPEINFO_IS_HO' macro might be a good idea...

> +		/*
> +                ** Check for type variables -- if there are none,
> +                ** we don't need to create a new type_info.
> +                */

Indentation problem (mixing spaces and tabs).

> BEGIN_MODULE(mercury__builtin_unify_pred_module)
> 
> BEGIN_CODE
> 
> /* code for predicate 'builtin_unify_pred'/2 in mode 0 */
> mercury__builtin_unify_pred_2_0:
>         incr_sp_push_msg(2, "mercury_builtin:builtin_unify_pred");
> 	fatal_error("attempted unification of higher-order terms");
> END_MODULE

Indentation problem (mixing spaces and tabs).

In fact the call to incr_sp_push_msg() is not really necessary.

> /* code for predicate 'builtin_compare_pred'/3 in mode 0 */
> mercury__builtin_compare_pred_3_0:
>         incr_sp_push_msg(2, "mercury_builtin:builtin_compare_pred");
> 	fatal_error("attempted comparison of higher-order terms");
> END_MODULE

Ditto.

-- 
Fergus Henderson <fjh at cs.mu.oz.au>   |  "I have always known that the pursuit
WWW: <http://www.cs.mu.oz.au/~fjh>   |  of excellence is a lethal habit"
PGP: finger fjh at 128.250.37.3         |     -- the last words of T. S. Garp.



More information about the developers mailing list