[m-dev.] for review: rewrite of duplicate elimination.

[Tyson Dowd]

On 22-Dec-1997, Zoltan Somogyi <zs at cs.mu.oz.au> wrote:
> 
> Tyson writes:
> 
> > It would also be good to have a small test case that triggers this
> > optimization for the test suite.
> 
> There is no need. Several modules of the compiler and the library
> are affected, and dupelim is turned on by the default opt level.
> If something goes wrong, the bootcheck will fail. (This is true of
> all LLDS-to-LLDS optimizations and most other optimizations, since I get
> most ideas for such optimizations from examining the code of the compiler.)

There is no need for such a test case to detect that *something* has
gone wrong. The test is very handy for testing whether the something
that has gone wrong is that a particular LLDS-to-LLDS transformation no
longer works (although it's a one way test). 
I'll concede that this is only of limited utility, and probably not worth
worrying about too much in this case if you don't have a test case laying
about.

> 
> A diff to address your other points (and to fix a silly typo, 5 -> 6) follows.
> 

These changes are fine. 

-- 
       Tyson Dowd           # If I'm unusually agressive in this email, it's
                            # probably because USENET has been down here for
     trd at cs.mu.oz.au        # over a week, and I'm missing my usual dosage
http://www.cs.mu.oz.au/~trd # of flamewars. My apologies in advance.