[m-dev.] for review: rewrite of termination analysis (part 2)

Zoltan Somogyi zs at cs.mu.oz.au
Mon Dec 22 16:50:12 AEDT 1997


Chris wrote:
> Is it worth documenting that "setting this limit to zero disables single
> argument termination analysis"?

> > +	% Given a bag, produce a sorted list containing all the values in
> > +	% the bag.  Each value will appear in the list once, with the
> > +	% associated value giving the number of times that it appears
> > +	% in the bag.
> > +:- pred bag__to_assoc_list(bag(T), assoc_list(T, int)).
> > +:- mode bag__to_assoc_list(in, out) is det.
> > +
> This comment should be clarified.  Currently `value' is used to refer to
> both the values stored in the bag, and the integer describing the number
> of times each value occurs.  

> Is there a particular reason that this predicate is not implemented as
> list__take_upto(N, As, Bs) :-
> 	( list__take(N, As, Bs0) ->
> 		Bs = Bs0
> 	;
> 		Bs = As
> 	).

All three suggestions adopted.

Zoltan.



More information about the developers mailing list