[m-dev.] cvs diff: type_info code (round 2)

Tyson Richard DOWD trd at hydra.cs.mu.oz.au
Mon Apr 21 16:06:01 AEST 1997


> 
> > +static int 	get_functor_info(Word type_info, int functor_number, 
> > +				Construct_Info *info);
> 
> That shouldn't be declared static, because of `--split-c-files',
> cross-module inlining, etc.

This isn't used by any other pragma c_codes. It should be declared at
the top of the block instead, so I've done that.

> 
> > +int
> > +ML_typecheck_arguments(Word type_info, int arity, Word arg_list,
> > +		Word* arg_vector) 
> > +{
> > +	int i, success;
> > +	Word arg_type_info, list_arg_type_info;
> > +
> > +		/* Type check list of arguments */
> > +
> > +	for (i = 0; success && i < arity; i++) {
> 
> That's a bug.  The success variable is uninitialized.
> I suggest that you get rid of it (as I said originally).

Ooops, thought I'd fixed that, sorry.

-- 
       Tyson Dowd           #
                            #             Sign on refrigerator:
     trd at cs.mu.oz.au        #           Refrigerate after opening. 
http://www.cs.mu.oz.au/~trd #                  - C. J. Owen.



More information about the developers mailing list