[m-rev.] for review of the idea: don't add unneeded parens around sym_names

Julien Fischer jfischer at opturion.com
Wed Feb 7 22:38:39 AEDT 2024


On Wed, 7 Feb 2024, Zoltan Somogyi wrote:

> The diff is trivial, the only thing worth reviewing is whether
> the cost is worth the benefit. The cost is the execution
> of two tests per qualified sym_name being written out
> (to e.g. intN or .*opt files). Since the value being tested
> will almost always be the same (saying that the sym_name
> is NOT next to a graphic symbol), the tests will be predicted
> correctly in almost all cases by modern CPUs, so this cost
> is minimal. The benefit is that diagnostic output that previously
> contained redundant parentheses will now be slightly easier
> to read.
>
> For opinions by anyone.

I think the removal of clutter in the error messages makes it worth.
(I can't imagine the runtime cost would be noticeable.)

Julien.


More information about the reviews mailing list