[m-rev.] for review: type_spec_constrained_preds

Julien Fischer jfischer at opturion.com
Wed Feb 7 16:50:14 AEDT 2024


On Wed, 7 Feb 2024, Zoltan Somogyi wrote:

> On 2024-02-07 13:58 +11:00 AEDT, "Julien Fischer" <jfischer at opturion.com> wrote:
>>>> vim/syntax/mercury.vim:
>>>     List the new pragma name.
>>
>> You've already listed this change above.
>
> Duplicate deleted.
>
>>> +    % Values of this type represent the set of typeclass constraints
>>> +    % we want to specialize. Each class_id in here will correspond
>>> +    % either to a constraint in a type_spec_constrained_preds pragma,
>>> +    % one its superclasses, or one of *their* superclasses, and so on.
>>> +    % We may be on the lookout for more than one instance of a class.
>>
>> may or must?
>
> We *must* be on the lookout for all instances of a class that are also instances
> of a constraint in the new pragma (this being the set of constraints we want to specialize),
> and this *all* quantifier *may* rerpresent one instance, or more than one.
> (For zero instances, the map won't have an entry for that class.)

How about:

    We may be on the lookout for more than one instance of a given class,
    since the constraints in the pragma may refer to multiple instances
    of that class.

Julien.


More information about the reviews mailing list