[m-rev.] for tryout: type_spec_constrained_preds

Zoltan Somogyi zoltan.somogyi at runbox.com
Thu Feb 1 14:08:25 AEDT 2024


On 2024-02-01 01:06 +11:00 AEDT, "Julien Fischer" <jfischer at opturion.com> wrote:
> I will post something regarding the JSON library tomorrow or Friday;
> it's the more interesting of the two.

If you have not yet started on this, then don't. I know what is causing
at least the first compiler error with your csv program, and I should have
a fix in the next couple of hours. When I do, I will post it here.

>> Would you mind if I copied some parts of your csv and/or json libraries
>> to the test case for this diff?
> 
> Feel free to, they're released under a BSD-style license anyway.

Thanks.

>> The pred id on the call should tell you which version is being called.
>> ( don't think the code that redirects the call to the specialized version
>> changes the *name* of the callee in the plain_call goal_expr, since the
>> name is not used by any of the later passes, but it has to change the pred_id.
>>
>> To make HLDS dumps easier to read, I will look into making this code
>> update the name field as well, as a separate change.

I have looked into this, and higher_order.m DOES update the callee's name
as well as its pred_id when it specializes a call, and has done so for a long time.

Zoltan.


More information about the reviews mailing list