[m-rev.] for post-commit review: extend "did you mean" suggestions to other kinds of entities

[Julien Fischer]

On Tue, 26 Sep 2023, Zoltan Somogyi wrote:

> Extend "did you mean" suggestions beyond preds.
> 
> compiler/typecheck_error_undef.m:
>     Suggest possible "did you mean" names when reporting references
>     to undefined functions, not just undefined predicates.
>
>     Generalize the infrastructure used for predicate name suggestions
>     to work for function name suggestions as well.
>
>     Delete the code moved to error_spec.m.
> 
> compiler/module_qual.qual_errors.m:
>     When reporting an undefined entity name that has way to become defined
>     without changing its name, suggest possible names.
> 
> compiler/error_spec.m:
>     Move the code for constructing "did you mean" suggestions here from
>     typecheck_error_undef.m, to make it accessible from
>     module_qual.qual_errors.m as well.
> 
> compiler/hlds_cons.m:
>     Add a way to retrieve the names of all the function symbols,
>     for use by the new code in typecheck_error_undef.m.
> 
> compiler/module_qual.id_set.m:
>     Add a way to retrieve the names of all the ids in an id_set,
>     for use by the new code in module_qual.qual_errors.m.
>
>     Expand a old comment.
> 
> tests/invalid/bug113.err_exp:
> tests/invalid/multiply_star.err_exp:
> tests/invalid/multiply_star.m:
> tests/invalid_nodepend/kind.err_exp:
> tests/invalid_nodepend/reserved_type_name.err_exp:
>     Expect the "did you mean" messages we now generate.

That looks fine.

Julien.