[m-rev.] for possible post-commit review: carve three modules out of make.dependencies.m

Julien Fischer jfischer at opturion.com
Sun Sep 17 20:24:14 AEST 2023


On Sun, 17 Sep 2023, Zoltan Somogyi wrote:

> Carve three new modules out of make.dependencies.m.
> 
> Each of the new modules, and the old one, have improved cohesion.

...

> diff --git a/compiler/make.deps_cache.m b/compiler/make.deps_cache.m
> index e69de29bb..8d5608806 100644
> --- a/compiler/make.deps_cache.m
> +++ b/compiler/make.deps_cache.m
> @@ -0,0 +1,104 @@
> +%---------------------------------------------------------------------------%
> +% vim: ft=mercury ts=4 sw=4 et
> +%---------------------------------------------------------------------------%
> +% Copyright (C) 2023 The Mercury team.
> +% This file may only be copied under the terms of the GNU General
> +% Public License - see the file COPYING in the Mercury distribution.
> +%---------------------------------------------------------------------------%
> +%
> +% File: make.deps_cache.m.
> +%

Add a brief summary of what this module contains (e.g. what you've put in the
compiler design doc.)

...

> diff --git a/compiler/make.find_local_modules.m b/compiler/make.find_local_modules.m
> index e69de29bb..7bb58eaad 100644
> --- a/compiler/make.find_local_modules.m
> +++ b/compiler/make.find_local_modules.m
> @@ -0,0 +1,243 @@
> +%---------------------------------------------------------------------------%
> +% vim: ft=mercury ts=4 sw=4 et
> +%---------------------------------------------------------------------------%
> +% Copyright (C) 2023 The Mercury team.
> +% This file may only be copied under the terms of the GNU General
> +% Public License - see the file COPYING in the Mercury distribution.
> +%---------------------------------------------------------------------------%
> +%
> +% File: make.find_local_modules.m.
> +%
> +%---------------------------------------------------------------------------%

Ditto.

That looks fine otherwise.

Julien.


More information about the reviews mailing list