[m-rev.] for review: support optional package version information

Zoltan Somogyi zoltan.somogyi at runbox.com
Sat Sep 9 14:36:10 AEST 2023


On 2023-09-09 14:19 +10:00 AEST, "Julien Fischer" <jfischer at opturion.com> wrote:
> 
> On Sat, 9 Sep 2023, Zoltan Somogyi wrote:
> 
>> On 2023-09-09 00:43 +10:00 AEST, "Julien Fischer" <jfischer at opturion.com> wrote:
>>> library/library.m:
>>>     Add version/3, which returns the package version string in addition
>>>     to the version and fullarch strings.
>>
>> I have a slight preference for separate predicates (or functions)
>> returning the Mercury version, the package version, and the fullarch,
>> but I can see that there is no point in switching to that now.
>> However, I think it would be better to add any NEW info, such as the
>> package version, as something you can get on its own.
> 
> Ok, I've removed version/3 and added the function package_version/0.
> I suggest we add the following functions as well:
> 
>   :- func mercury_version = string. % Returning MR_VERSION
>   :- func architecture  = string.   % Return MR_FULLARCH

Yes, that's what I had in mind.

> (We can deprecated version/2 eventually.)

We can, but I don't see much point. The main impact of deleting
obsolete functions/predicates is to reduce the compile time of
other modules that import this one, and in this case, such modules
will be few and far between.

Zoltan.


More information about the reviews mailing list