[m-rev.] systematic problem with tests/valid* for C#

Zoltan Somogyi zoltan.somogyi at runbox.com
Tue Oct 3 23:24:23 AEDT 2023


On 2023-10-02 19:24 +11:00 AEDT, "Julien Fischer" <jfischer at opturion.com> wrote:
>> We have long had .all_cs as a synonym for .cs for this exact reason
>> (just as we have .all_os as a synonym for .os), but stopped short of
>> switching the meaning of a target with a .cs suffix to mean a C# source file.
>>
>> Would anyone object to making that step now?
> 
> No.

The attached diff does this. It bootchecks in C grades with and without --intermod-opt.
It bootchecks in Java grade with the same number of test failures as before,
and it bootchecks in C# with a reduced number of test fails, because the diff
fixes the old fails caused by the mismatch in the meaning of target cs, as intended.

>> Specifically, I propose that both mmake and mmc --make should have the
>> rule that ONLY the suffix  ".all_Xs" means "all .X files".
> 
> That's fine.

I made a start on this, but found a problem that prevented me from going there
immediately. The problem is explained in the third point added to NEWS.md.

The diff is for review by anyone. The changes in it should be reflected by changes
in the user guide, but I would like to see your review comments for NEWS.md
before I make those changes.

This is a sort-of unusual diff to review, because the main possible source of error in it
is not the presence of some change in the attached diff, but the *absence* of a change
in some file that would be needed to conform the changes that *are* in the diff.
I would like reviewers to tell me if they know of any places that need such an update.

For the change to NEWS.md, I am seeking feedback both about its wording, and
the use of markup. For example, is there some standard way to communicate
the meta-syntactic nature of `name` and `program`  in the newly added text?
And I would also like to know whether we should talk about C#-related mmake vars,
given that we don't support use of mmake for C#.

Zoltan.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: Log.mtv
Type: application/octet-stream
Size: 4444 bytes
Desc: not available
URL: <http://lists.mercurylang.org/archives/reviews/attachments/20231003/8243e773/attachment-0002.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: DIFF.mtv
Type: application/octet-stream
Size: 72598 bytes
Desc: not available
URL: <http://lists.mercurylang.org/archives/reviews/attachments/20231003/8243e773/attachment-0003.obj>


More information about the reviews mailing list