[m-rev.] for post-commit review: update style of some scripts

Julien Fischer jfischer at opturion.com
Sun Oct 1 13:05:52 AEDT 2023


On Sat, 30 Sep 2023, Zoltan Somogyi wrote:

> Update the programming style of some scripts.
> 
> scripts/init_grade_options.sh-subr:
> scripts/mdb.in:
> scripts/mercury_config.in:
> scripts/mercury_update_interface.in:
> scripts/mgnuc.in:
> scripts/ml.in:
> scripts/parse_ml_options.sh-subr.in:
>     Indent by four spaces, not by tabs, or by three spaces.
>
>     Use ${varname}, not just $varname.
>
>     Put successive commands on separate lines.
>
>     Indent case statements in a consistent manner: put case patterns
>     on their own lines; put ;;s on their own lines.
>
>     Replace the [ command with test.
>
>     Put quotes around strings that should be considered one word
>     even if they are empty or contain spaces.
>
>     Fix English in messages and comments.

That looks fine.

Julien.


More information about the reviews mailing list