[m-rev.] for review: deprecate --no-ansi and --no-ansi-c

[Julien Fischer]

Hi Peter,

On Wed, 31 May 2023, Peter Wang wrote:

> On Wed, 31 May 2023 12:47:21 +1000 Julien Fischer <jfischer at opturion.com> wrote:
>>
>> For review by anyone.
>> ---------------------
>>
>> Deprecate --no-ansi and --no-ansi-c.
>
>> diff --git a/compiler/options.m b/compiler/options.m
>> index ac1b4fe..ecbab5a 100644
>> --- a/compiler/options.m
>> +++ b/compiler/options.m
>> @@ -6333,9 +6333,7 @@ options_help_target_code_compilation(Stream, !IO) :-
>>           "\tDon't enable the C compiler's optimizations.",
>>
>>           "--no-ansi-c",
>> -        "\tDon't specify to the C compiler that the ANSI dialect",
>> -        "\tof C should be used. Use the full contents of system",
>> -        "\theaders, rather than the ANSI subset.",
>> +        "\tThis option is deprecated and does not have any effect.",
>>
>>           "--c-debug",
>>           "\tEnable debugging of the generated C code.",
>
> Do we normally leave delete deprecated options in help text?

We've done both in the past. Given the length of time that option has
existed, I think it's preferable for it to not suddenly disappear
without some explanation.

>> diff --git a/doc/user_guide.texi b/doc/user_guide.texi
>> index 07682ce..a06b1f5 100644
>> --- a/doc/user_guide.texi
>> +++ b/doc/user_guide.texi
>> @@ -9977,9 +9977,7 @@ Don't enable the C compiler's optimizations.
>>   @sp 1
>>   @item --no-ansi-c
>>   @findex --no-ansi-c
>> -Don't specify to the C compiler that the ANSI dialect
>> -of C should be used.  Use the full contents of system
>> -headers, rather than the ANSI subset.
>> +This option is deprectaed and has no effect.
>
> deprecated

Fixed.

> That looks fine.

Thanks for that.  BTW, I wasn't sure what the appropriate way of
removing the references to --no-ansi in the Boehm GC makefiles was.
I assume it just best to wait until the next GC update and remove
them then?

Julien.