[m-rev.] request for opinions: string.format_table_max output

Julien Fischer jfischer at opturion.com
Tue May 23 11:24:06 AEST 2023


On Mon, 22 May 2023, Zoltan Somogyi wrote:

>
> On 2023-05-22 17:39 +10:00 AEST, "Zoltan Somogyi" <zoltan.somogyi at runbox.com> wrote:
>>> s/Nth/N'th/ (which is what we use almost everywhere else in the library documentation).
>>
>> WIll fix.
>
> The attached diff does this, and includes Peter's catch. I am
> commit it.
>
> The only thing left to discuss is whether the change to format_table_max's
> (previously undocumented) treatment of column width limits is
> worth an entry in the NEWS file, either for string.m, or in the breaking
> changes section. I would think yes and no respectively, but I am willing
> to be persuaded otherwise.

It should be mentioned in the changes for string.m.

Julien.


More information about the reviews mailing list