[m-rev.] for post-commit review: start updating mlds_to_c_type.m

Julien Fischer jfischer at opturion.com
Mon May 15 09:02:02 AEST 2023


On Mon, 15 May 2023, Zoltan Somogyi wrote:

> Make mlds_to_c_type.m do its job in functions.
> 
> compiler/mlds_to_c_type.m:
>     For every predicate that writes out the string form of an entity,
>
>     - add a function that just returns the string form, and
>     - reimplement the predicate in terms of that function.
> 
> compiler/mlds_to_c_data.m:
>     Switch to using the new functions in mlds_to_c_type.m, and to using
>     indent.m's facilities for indentation.

That looks fine. (I assume the bits you've commented out and ZZZs will
be addressed in upcoming changes.)

Julien.


More information about the reviews mailing list