[m-rev.] for review: updates for Boehm GC build system

Peter Wang novalazy at gmail.com
Wed Jun 28 16:59:03 AEST 2023


On Wed, 28 Jun 2023 16:38:31 +1000 Julien Fischer <jfischer at opturion.com> wrote:
> 
> For review by Peter.
> 
> With the diff below, Mercury now bootstraps with the 64-bit version of 
> MSVC in hlc.gc.  (There are a handful of test failures due to "Windows 
> things", but it otherwise works.)
> 
> I'm not sure what the procedure is for making changes to our local 
> modifications to the Boehm collector -- there is a document in
> compiler/notes but it is about updating the gc as a whole.
> 

First, commit the changes on the release-8_0-mercury branch of our bdwgc
repository. Add a tag named release-8_0-mercury-YYYYMMDD.
Push the changes and the tag.

Next, check out the tag in the mercury/boehm_gc submodule.
"git status" will say that the boehm_gc has been modified.
You can git add and commit that change.

(If we were switching to a different branch in the boehm_gc submodule,
you'd update .gitmodules as well.)

The diff looks fine.

Peter


More information about the reviews mailing list