[m-rev.] for post-commit review: give "current dir" extensions their own categories

Zoltan Somogyi zoltan.somogyi at runbox.com
Tue Jun 6 13:57:15 AEST 2023


On 2023-06-06 03:39 +02:00 CEST, "Julien Fischer" <jfischer at opturion.com> wrote:
>> +    ;       newext_mh(string)
>> +            % Machine-dependent header files for generated C code.
>> +            % The extension string is ".mh".
> 
> What do .mh files contain that is machine dependent (other than the
> comment at their head containing FullArchName)?

I don't know. I do remember that .mih stands for "machine independent header",
and .mh lacks the "i". To the best of my knowledge, Fergus never documented
his rationale of what goes into each kind of header file.

I have replaced that sentence with

Information about Mercury code exported to outside C code.

based on what export.m puts into .mh files.

>> +
>> +    ;       newext_user(string)
>> +            % Compiler-generated files that are intended to be read
>> +            % by the programmer, such as .err files.
>> +
>> +    ;       newext_make(string)
>> +            % These suffixes are used not to create filenames, but to
>> +            % create mmake target names. So do refer to real files,
> 
> Missing word there.
> 
>> +            % but they can (and some do) refer to these using exnetsion
> 
> 
> s/exnetsion/extension/

Both are already fixed.

Thanks for the review.

Zoltan.


More information about the reviews mailing list