[m-rev.] for post-commit review: better diagnostic for missing higher order insts

Zoltan Somogyi zoltan.somogyi at runbox.com
Wed Jul 19 08:06:21 AEST 2023


For review by everyone, if possible.

Questions I would like feeback on:

- Is the set of pieces of information it conveys right?
  Is it missing any important info?
  Does it include info it shouldn't?

- Is the structure of the error message, the general approach
  it uses to convey the info it conveys, broadly right?
  If not, there is no point in discussing its details.

- If the structure is right, are the details of its text right?

- Can anyone propose an alternative that is better than
  the use of the _t and _i suffixes to distinguish the
  type and inst names?

- The text would probably be improved if we added blank lines
  (it would break up the "wall" of text). If so, where should
  the blank lines go?

- Should anything not currently quoted be quoted, or vice versa?

Zoltan.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: Log.nhoi
Type: application/octet-stream
Size: 699 bytes
Desc: not available
URL: <http://lists.mercurylang.org/archives/reviews/attachments/20230719/3a52b69d/attachment-0002.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: DIFF.nhoi
Type: application/octet-stream
Size: 9517 bytes
Desc: not available
URL: <http://lists.mercurylang.org/archives/reviews/attachments/20230719/3a52b69d/attachment-0003.obj>


More information about the reviews mailing list