[m-rev.] for post-commit review: add remaining X_to_string and format_X ops

Zoltan Somogyi zoltan.somogyi at runbox.com
Wed Jul 5 00:34:38 AEST 2023


On 2023-07-04 13:20 +02:00 CEST, "Julien Fischer" <jfischer at opturion.com> wrote:
> 
> 
> On Tue, 4 Jul 2023, Zoltan Somogyi wrote:
> 
>> Should we move the varset argument of write_variable
>> and related ops to *before* the var argument?
> 
> IMO, yes.

The attached diff, which I am now committing,
does this. The only part worth reviewing is the change
to NEWS.md.

>> It would be consistent with the argument order
>> of the write_term ops, and more conducive to
>> folds over lists/sets of variables.
> 
> The diff looks fine.

Thank you.

Zoltan.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: Log.tio6
Type: application/octet-stream
Size: 622 bytes
Desc: not available
URL: <http://lists.mercurylang.org/archives/reviews/attachments/20230705/fe675685/attachment.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: DIFF.tio6
Type: application/octet-stream
Size: 8038 bytes
Desc: not available
URL: <http://lists.mercurylang.org/archives/reviews/attachments/20230705/fe675685/attachment-0001.obj>


More information about the reviews mailing list