[m-rev.] for review: method_infos

Zoltan Somogyi zoltan.somogyi at runbox.com
Thu Nov 24 11:35:48 AEDT 2022


2022-11-22 11:03 GMT+11:00 "Julien Fischer" <jfischer at opturion.com>:
>> Ideally, it should be "the longest vector that fits on one line", but the code
>> constructing the error message does not know what fits, and it would be
>> hard to give it access to that info. So we need a heuristic. It seems that we
>> both agree that class(foo, bar) is fine, and class(foo_bar, baz, quux) is not fine,
>> so the only question is: is class(foo, bar, baz) fine? I have no strong opinion
>> on that, so I will update the code with whatever limit you pick.
> 
> I think the threshold should be at greater than 5 arguments.

The attached diff implements this. For your post-commit review.
And the next time you get a real-life error for an instance with more than five
types, we can add it to the test suite.

Zoltan.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: Log.ct2
Type: application/octet-stream
Size: 112 bytes
Desc: not available
URL: <http://lists.mercurylang.org/archives/reviews/attachments/20221124/64428c0d/attachment-0002.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: DIFF.ct2
Type: application/octet-stream
Size: 7224 bytes
Desc: not available
URL: <http://lists.mercurylang.org/archives/reviews/attachments/20221124/64428c0d/attachment-0003.obj>


More information about the reviews mailing list