[m-rev.] for review: Skip or delete tests that fail in low-level parallel grades.

Julien Fischer jfischer at opturion.com
Wed Nov 23 14:52:14 AEDT 2022



On Wed, 23 Nov 2022, Peter Wang wrote:

> Should we delete the hard_coded/parse test as well? It seems more
> trouble than it's worth.

That test case is currently testing two things:

1. What happens when a program has a module with the same name as
    a browser module (its original purpose).

2. --linkage static

(1) is still worthwhile. (2) is increasingly unsupported by most
operating systems out-of-the-box, so I think we could dispense with it.

> ---
>
> Since the compiler now refuses to allow debugging in parallel grades,
> tests that require debugging need to be skipped over in low-level
> parallel grades or deleted.
>
> tests/hard_coded/Mmakefile:
>    Disable 'parse' test in parallel grades as it happens to link with
>    debug libraries.
>
> tests/par_conj/Mercury.options:
> tests/par_conj/Mmakefile:
> tests/par_conj/par_ddeath.exp:
> tests/par_conj/par_ddeath.m:
> tests/par_conj/par_ddeath_2.exp:
> tests/par_conj/par_ddeath_2.m:
>    Delete par_ddeath and par_ddeath_2 tests that once triggered a
>    compiler abort with --trace deep in parallel grades.
>    I don't think there is much value in keeping them around.
>
> tests/valid/Mmake.valid.common:
>    Skip LLDS_PROGS (i.e. test cases that required debugging) in
>    parallel grades.
>
> tests/valid/Mercury.options:
> tests/valid/Mmakefile:
> tests/valid/untuple_bug.m:
>    Delete untuple_bug. It tests an old bug in the untupling
>    transformation, which was more a programming exercise than something
>    that should be used anyway.

That's fine.

Julien.


More information about the reviews mailing list