[m-rev.] diff: Fix value of maybe_string option when negated.

Julien Fischer jfischer at opturion.com
Tue Nov 8 17:13:22 AEDT 2022



On Tue, 8 Nov 2022, Peter Wang wrote:

> On Tue, 08 Nov 2022 16:26:05 +1100 Julien Fischer <jfischer at opturion.com> wrote:
>>
>> Hi Peter,
>>
>> On Tue, 8 Nov 2022, Peter Wang wrote:
>>
>>> library/getopt.m:
>>> library/getopt_io.m:
>>>    Fix bug where a negation option (--no-foo) would set the value of a
>>>    maybe_string option to maybe_int(no) instead of maybe_string(no)
>>>    in the option table.
>>
>> It looks like this will need to go on to the release branch as well.
>
> Right.

Just to be clear, I'll handle the release branch stuff.

>> It would be good to have a regression test for this one as well.
>
> Ok, how about this.

Thanks, that's fine.

Julien.


More information about the reviews mailing list