[m-rev.] for review: rename the .ll_debug grade component for hlc grades to .c_debug

Julien Fischer jfischer at opturion.com
Thu Dec 29 19:45:09 AEDT 2022


On Thu, 29 Dec 2022, Zoltan Somogyi wrote:

> 2022-12-28 13:29 GMT+11:00 "Julien Fischer" <jfischer at opturion.com>:
>>> I therefore propose the following scheme:
>>>
>>> - Both mmc and mgnuc should accept an option named --c-debug, which
>>>  should cause both to pass -g to the C compiler, *without* affecting the grade.
>>>
>>> - Both mmc and mgnuc should accept an option named --c-debug-grade,
>>>  which will add .c_debug to the grade (for hlc grades), and will therefore
>>>  also pass -g to the C compiler.
>>>
>>> The internal variables in the compiler and in shell scripts should also follow
>>> this naming scheme, which should
>>>
>>> - suggest what the difference between the two options is, and
>>> - should make it easy to fully document that difference in the user guide
>>>  and in help messages.
>>>
>>> Any objections, or suggestions for better naming schemes?
>>
>> No, that scheme seems fine.
>
> The attached updated diff implements the above proposal.
> It has passed bootcheck in hlc.gc and hlc.gc.c_debug grades,
> and an install that includes both those grades is now in progress.
> For review by Julien.

That's fine.

Julien.


More information about the reviews mailing list