[m-rev.] for review: Enable munmap support in Boehm GC by default.

Peter Wang novalazy at gmail.com
Tue Dec 7 11:27:03 AEDT 2021


On Tue, 07 Dec 2021 01:51:55 +1100 Julien Fischer <jfischer at opturion.com> wrote:
> 
> Hi Peter,
> 
> On Tue, 30 Nov 2021, Peter Wang wrote:
> 
> > Julien, do you want me to wait until after the next ROTD before
> > committing this?
> >
> > ----
> >
> > configure:
> >    Change default value of enable_gc_mmap and enable_gc_munmap to yes.
> >
> >    Invert sense of --enable-gc-mmap and --enable-gc-munmap options in
> >    the help text.
> >
> > NEWS:
> >    Announce change.
> 
> You can go ahead and commit this one.

Ok, done.

I've also updated Boehm GC with a small fix for this warning when
compiling for Windows:

misc.c:1441:31: warning: passing argument 1 of ‘DeleteCriticalSection’ from incompatible pointer type [-Wincompatible-pointer-types]

Peter


More information about the reviews mailing list