[m-rev.] for review: reducing string table size

Zoltan Somogyi zs at csse.unimelb.edu.au
Mon Sep 26 14:27:12 AEST 2011


On 22-Sep-2011, Julien Fischer <juliensf at csse.unimelb.edu.au> wrote:
>
> On Wed, 21 Sep 2011, Zoltan Somogyi wrote:
>
>> Reduce the size of the string tables in debuggable executables by encoding
>> variable names that a few standard templates, the most important of which
>> is STATE_VARIABLE_name_number.
>
>     that are _of_ a few standard templates ... ?

... that fit a few standard templates ...

>> +MR_name_in_string_table(const char *string_table, MR_Integer 
>> string_table_size,
>> +    MR_uint_least32_t name_code, int *should_copy)
>> +{
>> +    // The encoding decoded here is create by lookup_string_in_table
>> +    // in compiler/stack_layout.m. The code here and there must be kept
>> +    // in sync.
>
> I would still avoid using //-style comments in places where it isn't
> absolutely clear that the C compiler supports them.

Ok for now. But // was added in C99, 12 years ago. I say we add a test
to configure.in, and start using //.

Zoltan.
--------------------------------------------------------------------------
mercury-reviews mailing list
Post messages to:       mercury-reviews at csse.unimelb.edu.au
Administrative Queries: owner-mercury-reviews at csse.unimelb.edu.au
Subscriptions:          mercury-reviews-request at csse.unimelb.edu.au
--------------------------------------------------------------------------



More information about the reviews mailing list