Hi Peter,<div><br></div><div>The diff is fine — UU is indeed a typo.</div><div><br></div><div>Julien.<br><br>On Monday, 19 March 2018, Peter Wang <<a href="mailto:novalazy@gmail.com">novalazy@gmail.com</a>> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">On Mon, 19 Mar 2018 14:40:59 +1100, Peter Wang <<a href="mailto:novalazy@gmail.com">novalazy@gmail.com</a>> wrote:<br>
> diff --git a/runtime/<a href="http://mercury_conf.h.in" target="_blank">mercury_conf.h.in</a> b/runtime/<a href="http://mercury_conf.h.in" target="_blank">mercury_conf.h.in</a><br>
> index 8801b6805..b7b613f17 100644<br>
> --- a/runtime/<a href="http://mercury_conf.h.in" target="_blank">mercury_conf.h.in</a><br>
> +++ b/runtime/<a href="http://mercury_conf.h.in" target="_blank">mercury_conf.h.in</a><br>
> @@ -363,6 +363,9 @@<br>
> #undef MR_HAVE_FINITE<br>
> #undef MR_HAVE_FESETROUND<br>
> #undef MR_HAVE_FMA<br>
> +#undef MR_HAVE_BUILTIN_BSWAP16<br>
> +#undef MR_HAVE_BUILTIN_BSWAP32<br>
> +#undef MR_HAVE_BUILTIN_BSWAP64<br>
<br>
I've now added comments describing these macros above.<br>
<br>
> diff --git a/runtime/mercury_int.h b/runtime/mercury_int.h<br>
> index bb8fbdf6f..9620953ff 100644<br>
> --- a/runtime/mercury_int.h<br>
> +++ b/runtime/mercury_int.h<br>
> @@ -94,7 +94,7 @@<br>
> extern MR_Integer MR_hash_int64(int64_t);<br>
> extern MR_Integer MR_hash_uint64(uint64_t);<br>
><br>
> -#if defined(MR_GNUC) || defined(MR_CLANG)<br>
> +#if defined(MR_HAVE_BUILTIN_<wbr>BSWAP16)<br>
> #define MR_uint16_reverse_bytes(U) __builtin_bswap16((U))<br>
> #elif defined(MR_MSVC)<br>
> #define MR_uint16_reverse_bytes(U) _byteswap_ushort((U))<br>
> @@ -103,7 +103,7 @@ extern MR_Integer MR_hash_uint64(uint64_t);<br>
> ((U & 0x00ff) << 8))<br>
> #endif<br>
><br>
> -#if defined(MR_GNUC) || defined(MR_CLANG)<br>
> +#if defined(MR_HAVE_BUILTIN_<wbr>BSWAP32)<br>
> #define MR_uint32_reverse_bytes(U) __builtin_bswap32((U))<br>
> #elif defined(MR_MSVC)<br>
> #define MR_uint32_reverse_bytes(U) _byteswap_ulong((U))<br>
> @@ -114,7 +114,7 @@ extern MR_Integer MR_hash_uint64(uint64_t);<br>
> (U & UINT32_C(0xff000000)) >> 24 )<br>
> #endif<br>
><br>
> -#if defined(MR_GNUC) || defined(MR_CLANG)<br>
> +#if defined(MR_HAVE_BUILTIN_<wbr>BSWAP64)<br>
> #define MR_uint64_reverse_bytes(U) __builtin_bswap64((U))<br>
> #elif defined(MR_MSVC)<br>
> #define MR_uint64_reverse_bytes(U) _byteswap_uint64((UU))<br>
<br>
UU is a typo, yes?<br>
<br>
Peter<br>
______________________________<wbr>_________________<br>
reviews mailing list<br>
<a href="mailto:reviews@lists.mercurylang.org">reviews@lists.mercurylang.org</a><br>
<a href="https://lists.mercurylang.org/listinfo/reviews" target="_blank">https://lists.mercurylang.org/<wbr>listinfo/reviews</a><br>
</blockquote></div>