<div dir="ltr">Hi Paul,<div><br><div class="gmail_extra"><div class="gmail_quote">On Thu, Apr 16, 2015 at 11:26 PM, Paul Bone <span dir="ltr"><<a href="mailto:paul@bone.id.au" target="_blank">paul@bone.id.au</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">On Tue, Apr 07, 2015 at 12:18:13PM +1000, Julien Fischer wrote:<br>
><br>
> compiler/compile_target_code.m:<br>
> Rename the link target type for Java executables.<br>
><br>
> Add a predicate for creating Java "executables": this involves generating<br>
> an archive (as we do for libraries) and then generating the wrapper script<br>
> or batch file.<br>
<br>
</span>There are a number of overlong lines in this patch.<br>
You'll need to check the whole patch.<br></blockquote><div><br></div><div>Ok, done. </div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
The semantics look fine.<br>
<br>
I think it would also be useful to generate .jar files for libraries. That<br>
can be a later patch that hopefully re-uses some of this work.</blockquote><div><br></div><div>I'm not sure what you mean. We already do generate .jar files for libraries</div><div>and have done so for years.</div><div><br></div><div>Cheers,</div><div>Julien.</div></div><br></div></div></div>