[m-rev.] for review: finish the "solution" of Mantis bug #585
Zoltan Somogyi
zoltan.somogyi at runbox.com
Mon Sep 14 18:15:02 AEST 2026
On Mon, 14 Sep 2026 11:11:48 +1000, Peter Wang <novalazy at gmail.com> wrote:
> > + % We say "debugging enabled", because this is by far
> > + % the most common way for body_typeinfo_liveness to be set.
> > + % Both alternatives, the use of .agc grades and manual setting
> > + % of the option, are extremely rare.
> > + MainPieces = [words("Sorry: he compiler cannot compile")] ++
>
> s/he/the
Done.
> Hmm, I didn't see why the diagnostic for test1 would disappear.
Thanks for catching that. I don't know why I didn't.
However, I just looked into that, and it is because in test1,
the typeclass info definitions in the separate k2 and k3 switch arms
are nested inside an if-then-else. I have a fix in mind, but first I will
commit this diff as is, with an amended log message, so you can
review the fix as a separate change.
> The rest looks fine.
Thanks.
More information about the reviews
mailing list