[m-rev.] diff: fix an incorrect check
Julien Fischer
jfischer at opturion.com
Tue Nov 3 00:20:42 AEDT 2026
On Tue, 3 Nov 2026 at 00:18, Zoltan Somogyi <zoltan.somogyi at runbox.com> wrote:
>
>
>
> On Tue, 3 Nov 2026 00:15:52 +1100, Julien Fischer <jfischer at opturion.com> wrote:
> > - if (MR_stack_margin_size_words >= (sizeof(MR_Word) * MR_detstack_size)) {
> > + if ((MR_stack_margin_size_words * sizeof(MR_Word)) >= MR_detstack_size) {
> > MR_fatal_error("MR_init_memory: stack margin size far too big");
>
> This strongly suggests that MR_detstack_size should be renamed
> to include the unit in its name.
Yes, there's already an XXX to that effect in mercury_wrapper.c; I intend
to address it.
Julien.
>
>
>
More information about the reviews
mailing list