[m-rev.] for review: improve the documentation of the calendar module

Julien Fischer jfischer at opturion.com
Sat Mar 14 15:43:18 AEDT 2026


On Sat, 14 Mar 2026 at 14:41, Zoltan Somogyi <zoltan.somogyi at runbox.com> wrote:
>
>
>
> On Sat, 14 Mar 2026 13:44:18 +1100, Julien Fischer <jfischer at opturion.com> wrote:
>
> > On Sat, 14 Mar 2026 at 12:59, Zoltan Somogyi <zoltan.somogyi at runbox.com> wrote:
> > >
> > > On Fri, 13 Mar 2026 20:05:46 +1100, Julien Fischer <jfischer at opturion.com> wrote:
> > > > > I don't like either version much; will propose changes after you commit.
> > > >
> > > > Feel free, although as I am actively working on this module at the moment,
> > > > could you please avoid touching the actual code.
> > >
> > > I am attaching my proposed changes for you to apply, possibly in
> > > a modified form.
> > >
> > > Note that I deleted the description of the leap year rule from the top-of-module
> > > comment because (a) the rest of the module barely mentions leap years, and
> > > (b) even if it had more mentions, that comment would not belong where it was.
> >
> > The diff is fine.
>
> Is this you asking me to commit it, or you saying that you will commit it?

Go ahead and commit it.

Julien.


More information about the reviews mailing list