[m-rev.] for post-commit review: add implicit rule to replace many bespoke rules
Zoltan Somogyi
zoltan.somogyi at runbox.com
Sat Mar 14 12:14:33 AEDT 2026
For review by anyone.
The implicit rule added by this diff using MDB_STD, which invokes mdb
with options that call for the standardization of event and call sequence
numbers. Many test use MDB, which does not do this.
When all test cases had a bespoke rule just for them, this was not an issue.
However, it is one now, because I would like to replace all those bespoke
rules as well, not just the ones deleted by this diff. I can see two ways
to do so.
The first way is to invoke all test cases that do not intrinsically need
a bespoke rule with MDB_STD, and let the intrinsic rule added by this diff
apply to them. This would require modifying their .exp* files, but this
should be easy to do.
The second way would involve
- setting up a list of test cases that would be invoked with MDB, and
another list that would be invoked with MDB_STD, and
- replacing the new implicit rule with a static pattern rule that applies
only to the test cases on the second list, and adding another static
pattern rule for the first list.
This would be tedious to set up, because we don't have a single list
of test cases that we can split into two sublists (actually we would need three,
with the third being for test cases that would not be covered by either
static pattern rule). Instead, we have several lists which differ by
being marked for execution under different sets of circumstances.
Dividing each of these lists into three sublists could be made to work,
but it would be ugly.
For this reason, I prefer the first way. Does anyone object to me
implementing it? In the absence of an objection by then, I intend to commit
such a change about this time tomorrow.
Zoltan.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: Log.dm2
Type: application/octet-stream
Size: 244 bytes
Desc: not available
URL: <http://lists.mercurylang.org/archives/reviews/attachments/20260314/4532bc7a/attachment.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: DIFF.dm2
Type: application/octet-stream
Size: 16636 bytes
Desc: not available
URL: <http://lists.mercurylang.org/archives/reviews/attachments/20260314/4532bc7a/attachment-0001.obj>
More information about the reviews
mailing list