[m-rev.] for review: fix bug #582
Julien Fischer
jfischer at opturion.com
Wed Mar 4 19:34:19 AEDT 2026
On Wed, 4 Mar 2026 at 07:58, Zoltan Somogyi <zoltan.somogyi at runbox.com> wrote:
>
> For review by Julien, since I would like his feedback about
> *checked* conversions from int64s, uint64s and uint32s to int32s.
There is no issue with adding such conversions. IIRC, when I added
fixed-size integer types, we discussed what conversions to add and
the ones above simply weren't on the list. (Presumably, no one felt
that they would be useful at the time.)
> And also, probably after Julien's review and my response to it,
> for tryout by Peter, since it is his bug report, and because I hope
> he has some tougher test cases.
>
> I have bootchecked the diff in both hlc.gc and asm_fast.gc,
> and checked that in those grades, we do get working lookup tables
> for switches on sized and/or unsigned integer values. It also looks like
> we get lookup tables in C# and Java grades as well, but I have just started
> the first of those bootchecks.
The diff itself looks fine. There's a missing word in the log message
below.
> Enable dense switches on sized and unsigned ints.
>
> Until now, the only integer type we generated dense switches
> (including lookup switches) for int itself; we did not do so
*was* int itself.
> for any sized and/or unsigned integer types.
Julien.
More information about the reviews
mailing list