[m-rev.] for post-commit review: do more kinds of check for all foreign_procs

[Zoltan Somogyi]

For review by anyone. The diff is with -b.

While doing these changes, I saw that we use wildly different terminology
to refer to the same entities (foreign_procs) in different diagnostic messages.
The three main patterns are these:

   "Error: foreign clause for predicate xyz ..."

   "In ':- pragma foreign_proc' declaration for predicate xyz ..."

   "In the C code for predicate xyz: ..."

I propose that we change all these diagnostics to either something like this:

     "In the C language ':- pragma foreign_proc' declaration for predicate xyz ..."

or to something like this:

   "In the C foreign_proc for predicate xyz ..."

The former is more formal and complete, the second is shorter.
I slightly prefer the second. What do you guys think? Do you have
another alternative you prefer to these?
   
Zoltan.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: Log.fpmw
Type: application/octet-stream
Size: 1111 bytes
Desc: not available
URL: <http://lists.mercurylang.org/archives/reviews/attachments/20260130/570baf96/attachment-0002.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: DIFF.fpmw
Type: application/octet-stream
Size: 27102 bytes
Desc: not available
URL: <http://lists.mercurylang.org/archives/reviews/attachments/20260130/570baf96/attachment-0003.obj>