[m-rev.] for review: ignore comments in foreign_procs for warnings

[Julien Fischer]

On Tue, 27 Jan 2026 at 22:02, Zoltan Somogyi <zoltan.somogyi at runbox.com>
wrote:

> For review by Peter, since it implements his feature request.
> The diff is with -b.
>
> Note that this diff does not update many .err_exp[23] files that hold
> warnings expected in C# and Java grades. The reason is that
> when I implement the change I proposed last night in note
> on issue #580, those files would go away.
>

This change has broken compilation of the standard library in deep
profiling grades.
It changes the CSD argument of many of the foreign_procs in
library/profiling_builtin.m
to be a don't-care variable, but all references to that argument in the
foreign proc body
are #included from the runtime.

/home/jfischer/mercury-builds/mercury-1.git/stage2/install_grade_dir.asm_fast.gc.profdeep.tr.stseg/scripts/mgnuc
--grade asm_fast.gc.profdeep.tr.stseg       --      -c profiling_builtin.c
-o profiling_builtin.o
In file included from profiling_builtin.m:973:
../runtime/mercury_deep_rec_depth_body.h: In function
‘profiling_builtin_module14’:
../runtime/mercury_deep_rec_depth_body.h:38:11: error: ‘CSD’ undeclared
(first use in this function); did you mean ‘CSN’?
../runtime/mercury_deep_rec_depth_body.h:38:11: note: each undeclared
identifier is reported only once for each function it appears in
In file included from profiling_builtin.m:994:
../runtime/mercury_deep_rec_depth_body.h: In function
‘profiling_builtin_module15’:
../runtime/mercury_deep_rec_depth_body.h:38:11: error: ‘CSD’ undeclared
(first use in this function)
In file included from profiling_builtin.m:1017:
../runtime/mercury_deep_rec_depth_body.h: In function
‘profiling_builtin_module16’:
../runtime/mercury_deep_rec_depth_body.h:38:11: error: ‘CSD’ undeclared
(first use in this function)
In file included from profiling_builtin.m:1043:
../runtime/mercury_deep_rec_depth_body.h: In function
‘profiling_builtin_module17’:
../runtime/mercury_deep_rec_depth_body.h:38:11: error: ‘CSD’ undeclared
(first use in this function)
In file included from profiling_builtin.m:1071:
../runtime/mercury_deep_rec_depth_body.h: In function
‘profiling_builtin_module18’:
../runtime/mercury_deep_rec_depth_body.h:38:11: error: ‘CSD’ undeclared
(first use in this function)
In file included from profiling_builtin.m:1101:
../runtime/mercury_deep_rec_depth_body.h: In function
‘profiling_builtin_module19’:
../runtime/mercury_deep_rec_depth_body.h:38:11: error: ‘CSD’ undeclared
(first use in this function)
In file included from profiling_builtin.m:1134:
../runtime/mercury_deep_rec_depth_body.h: In function
‘profiling_builtin_module20’:
../runtime/mercury_deep_rec_depth_body.h:38:11: error: ‘CSD’ undeclared
(first use in this function)

Julien.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mercurylang.org/archives/reviews/attachments/20260128/235800e1/attachment.html>