[m-rev.] for post-commit review: uints in edit_seq.m
Zoltan Somogyi
zoltan.somogyi at runbox.com
Thu Jan 1 18:01:34 AEDT 2026
On Thu, 1 Jan 2026 17:58:09 +1100, Julien Fischer <jfischer at opturion.com> wrote:
> Happy new year!
And to you, and to everyone else on this list.
> On Thu, 1 Jan 2026 at 17:22, Zoltan Somogyi <zoltan.somogyi at runbox.com> wrote:
> >
> > The concept has been agreed and the diff itself is straightforward.
> > The only part worth reviewing in the entry in NEWS.md. I would also
> > like to know if anyone objects to adding list.ulength, a version of
> > list.length that returns a uint, or if anyone has a better name for it.
>
> No objections from me, I have thought about adding myself in the past.
> If we are going to go down this road, then map.count, set.count etc should
> also have versions returning uints (e.g. ucount).
Will do. I presume you are ok with the naming scheme of putting a "u" in front
of the predicate and function names?
> > +* This module deals with many integers, including row numbers, column numbers,
> > + and operation costs) that cannot be negative. To ensure that this restriction
>
> That parenthesis shouldn't be there.
Fixed, and thanks.
Zoltan.
More information about the reviews
mailing list