[m-rev.] for post-commit review: fix a rare problem with subtype checks
Peter Wang
novalazy at gmail.com
Mon Aug 10 17:13:25 AEST 2026
On Sun, 09 Aug 2026 02:31:02 +0200 "Zoltan Somogyi" <zoltan.somogyi at runbox.com> wrote:
> For review by Peter. The diff is with -b.
>
> There is no test case yet, but after my next commit to it, the whole
> compiler directory will serve as one. I found the problem while
> working on that diff. Without this fix, dozens of files couldn't be
> compiled due to failed subtype checks on subtype definitions
> in .int2 files. The problem is simply that
>
> - if a .int file contains a subtype definition, then we pull in the .int2
> files that define the type_ctors that occur in the types of its right
> hand side,
>
> - but if a .int2 file contains a subtype definition, then we do nothing
> of the kind.
>
> All the failures were due to the definitions of those type_ctors
> simply not being available.
That looks okay.
Peter
More information about the reviews
mailing list