[m-rev.] for review: speed up string to int and string to uint conversion

Julien Fischer jfischer at opturion.com
Mon Aug 10 07:43:51 AEST 2026


On Mon, 10 Aug 2026 at 00:54, Zoltan Somogyi <zoltan.somogyi at runbox.com> wrote:

> > > I don't think CutOff and CutLimit are good names for these roles,
> > > because in a sense they are BOTH limits.
> > >
> > > A good name for CutOff would tell readers that this is the maximum
> > > that !.Int can be before the addition of a digit, and the CutLimit
> > > is the max value of that digit *if* !.Int = CutOff. However, right now
> > > I also cannot think of any *short* names that do that. Maybe
> > > something like MaxSoFar/MaxBeforeNextDigit and MaxNextDigit?
> >
> > MaxIntSoFar and MaxIntLastDigit?  (suitably adjusted for the negative case)
>
> I wouldn't use either of those names, because MaxIntSoFar is
> not the maximum of the values of !.Int so far, and MaxIntLastDigit is
> not necessarily the last digit of any of the values of !.Int up to now.
> Those two are LIMITS on !.Int and the next digit, not their PROPERTIES.
> A subtle difference, but I think an important one.

True. I will commit with the existing names for now and they can be renamed
when inspiration strikes.

Julien.


More information about the reviews mailing list