[m-rev.] for post-commit review: fix more tests/invalid failures

Julien Fischer jfischer at opturion.com
Mon Sep 15 12:48:12 AEST 2025


On Sun, 14 Sept 2025 at 14:28, Zoltan Somogyi <zoltan.somogyi at runbox.com> wrote:
> Fix some more tests/invalid failures.
>
> tests/invalid/illtyped_compare.err_exp2:
>     Add an expected output for target languages for which
>     unification pretests cast the input arguments to c_pointers,
>     not ints.

illtyped_compare.m needs to be updated with a comment explaining what
the different expected outputs are for.

> tests/invalid/pragma_c_code_dup_var.err_exp3:
> tests/invalid/pragma_c_code_no_det.err_exp3:
> tests/invalid/test_may_duplicate.err_exp3:
> tests/invalid/test_may_export_body.err_exp3:
> tests/invalid/try_detism.err_exp2:
> tests/warnings/foreign_singleton.err_exp3:
>     Update these expected output files to expect color in diagnostics,
>     and (in some cases) updated wording as well.

We should probably rename test cases that refer to "pragma_c_code", since
that hasn't been a pragma for a long time now.

That looks fine otherwise.

Julien.


More information about the reviews mailing list