[m-rev.] for review: extend final statevar warnings to lambda expression heads

Zoltan Somogyi zoltan.somogyi at runbox.com
Wed Oct 8 19:59:47 AEDT 2025



On Wed, 8 Oct 2025 19:47:51 +1100, Julien Fischer <jfischer at opturion.com> wrote:

> On Wed, 8 Oct 2025 at 02:49, Zoltan Somogyi <zoltan.somogyi at runbox.com> wrote:
> >
> > For review by anyone. I am particularly seeking feedback
> > on the move of some modules from the check_hlds package
> > to the hlds package that is mentioned in the diff to state_var.m.
> 
> Not an objection, but moving the modules you mention (inst_util,
> mode_util, inst_test and mode_test)
> into the hlds package wholesale would shift, rather than remove, the dependency
> between the hlds and check_hlds packages, since inst_util and inst_test import
> other packages from check_hlds.

Yes, I am aware of the issue. I intend to look into moving not just those modules,
but the check_hlds modules they depend on as well, provided they are not
closely linked to the process of checking the HLDS. If they *are*, then I intend
to split them. Do you object to this plan?

> The diff looks fine.

Thanks.

Zoltan.


More information about the reviews mailing list