[m-rev.] for review: warn about unneeded initial and final state vars

[Julien Fischer]

On Sun, 18 May 2025 at 22:29, Julien Fischer <jfischer at opturion.com> wrote:
>
> On Sun, 18 May 2025 at 07:25, Zoltan Somogyi <zoltan.somogyi at runbox.com> wrote:
> >
> > On Sun, 18 May 2025 02:32:17 +1000, Julien Fischer <jfischer at opturion.com> wrote:
> >
> > > On Fri, 16 May 2025 at 03:46, Zoltan Somogyi <zoltan.somogyi at runbox.com> wrote:
> > > > Add options to warn about unused state vars.
> > > > +            % with anoher clause that *does* use that same state variable.)
> > >
> > > s/anoher/another/
> >
> > Fixed.
> >
> > > That looks fine otherwise.
> >
> > Thanks for that. Attached is the rest of changes called for by the
> > new warnings, again for review by anyone. (There was a lot of unnecessary
> > passing of state vars, so it's big.)
>
> > Act on all remaining warnings about unused state vars.
>
> ...
>
> That's fine.

Actually, it wasn't quite fine :-(  A number of clauses that are only
used in non-C grades
trigger the new warning, some due to the issue that Peter reported
elsewhere in this
thread.  I have committed a fix for these issues.

Julien.