[m-rev.] for post-commit review: more specific warnings about unresolved polymorphism

[Zoltan Somogyi]

On Mon, 5 May 2025 15:03:20 +1000, Julien Fischer <jfischer at opturion.com> wrote:
> On Sat, 3 May 2025 at 17:46, Zoltan Somogyi <zoltan.somogyi at runbox.com> wrote:
> > +% Because this intention is to help with error messages created during
> > +% type analysis, this module does not look at, or use, any part of the HLDS
> > +% that is meaningful during type analysis, such as instmap_deltas.
> 
> I think you mean mode analysis there.

No, I meant type analysis, but there is a NOT missing from before "meaningful".
Fixed.

> > +:- pred update_var_origin(record_var_origin(T)::in(record_var_origin),
> > +    prog_var::in, var_origin::in,
> > +    var_origins_map::in, var_origins_map::out, T::in, T::out) is det.
> > +
> > +update_var_origin(CollectPred, Var, VarOrigin, !OriginsMap, !Acc) :-
> > +    ( if map.search(!.OriginsMap, Var, _VarOriginsCord0) then
> > +        % set.insert(VarOrigin, VarOriginsCord0, VarOriginsCord),
> > +        % map.det_update(Var, VarOriginsCord, !OriginsMap)
> > +        % ZZZ
> 
> 
> What's the ZZZ for?

To remind me to delete the previous two lines, if, as expected, they
turned out not to be needed. It didn't work :-(

I followed all your other suggestions. Thanks for the review.

Zoltan.