[m-rev.] for post-commit review: don't warn about redundant imports when making .int files

Julien Fischer jfischer at opturion.com
Mon May 5 15:06:35 AEST 2025


On Sun, 4 May 2025 at 04:35, Zoltan Somogyi <zoltan.somogyi at runbox.com> wrote:

> Report redundant imports only when generating code.
>
> compiler/convert_import_use.m:
>     Make the warnings we generate for imports that are redundant in
>     various ways all conditional on a flag that is explicitly switched off
>     when we generate .int files. The warnings served a purpose when they
>     signalled to the user that they needed to delete the redundant imports
>     if they wanted to avoid getting the same warning for every module that
>     depended on the bad module's .int file. Since the process for creating
>     .int files has automatically filtered out the redundant imports for
>     years now, this behavior is no longer needed.
>
> tests/invalid_make_int/redundant_import.{m,int_err_exp}:
>     A new test case for the suppression of redundant import warnings
>     when making .int files.
>
> tests/invalid_make_int/Mmakefile:
>     Enable the new test case.

That's fine.

Julien.


More information about the reviews mailing list