[m-rev.] for review: fix an inaccurate error message

[Julien Fischer]

On Sun, 30 Mar 2025 at 15:40, Zoltan Somogyi <zoltan.somogyi at runbox.com> wrote:

>
> On Sun, 30 Mar 2025 15:14:44 +1100, Julien Fischer <jfischer at opturion.com> wrote:
> > I have attached a test case for this bug.  I have not included it in
> > the diff because
> > I cannot make it work with any of the various invalid test directories we have.
> > (Rewriting it to use separate submodules has similar problems.) Suggestions
> > on where the test case should live would be appreciated.
>
> The diff itself is fine. I don't think it even needs a test case.

My hope was that by having a test case, it makes whoever next modifies the
code that produces the error at least consider what should happen in the case
of the module in the qualifier being an ancestor.

> If you do want to add one anyway, I would fix the issues reported by mmc
> first:

I had already done so, I think I sent an earlier version of the file.

...

> I would add the test case to invalid_submodules, after (a) fixing the warnings above,
> and (b) adding comments specifying the exact steps to reproduce the diagnostic.
> I would then add a comment to the Mmakefile saying that this test case is not enabled
> due the lack of a home for the test setup compatible with those steps.

Done.

Julien.