[m-rev.] for post-commit review: more of the same for warn/inform/mdb/opt options and more

Julien Fischer jfischer at opturion.com
Mon Jun 30 11:42:51 AEST 2025


On Mon, 30 Jun 2025 at 08:26, Zoltan Somogyi <zoltan.somogyi at runbox.com> wrote:
> Convert warn/inform/filereq/mdb/opt options to semantic help_pieces.

...


> diff --git a/tests/warnings/help_text.err_exp b/tests/warnings/help_text.err_exp
> index f9e8b9daf..e38e10c22 100644
> --- a/tests/warnings/help_text.err_exp
> +++ b/tests/warnings/help_text.err_exp

...

> @@ -1238,8 +1242,7 @@ Warning options
>
>      --no-warn-non-contiguous-decls
>          Do not generate a warning if the mode declarations of a predicate or
> -        function on't all immediately follow its predicate or function
> -        declaration.
> +        function don't all immediately follow its `pred' or `func' declaration.


s/don't/do not/

...

> @@ -1350,9 +1351,9 @@ Options that request information
>
>      PRIVATE OPTION
>      --inform-incomplete-color-scheme
> -        Report if the argument if either the value of the --color-scheme
> -        option, or the value of MERCURY_COLOR_SCHEME environment variable, does
> -        not specify a color for some role.
> +        Report if the argument if either the value of the `--color-scheme'
> +        option, or the value of the `MERCURY_COLOR_SCHEME' environment
> +        variable, does not specify a color for some role.


s/if either/of either/

That looks fine otherwise.

Julien.


More information about the reviews mailing list