[m-rev.] for post-commit review: use semantic help_pieces in infer/semantics/verbosity help texts

Julien Fischer jfischer at opturion.com
Mon Jun 30 11:20:50 AEST 2025


On Mon, 30 Jun 2025 at 04:35, Zoltan Somogyi <zoltan.somogyi at runbox.com> wrote:

> Convert infer/semantics/verbosity options to semantic help_pieces.
>
> compiler/options.m:
>     As above. In the process, rewrite many options' help texts a bit
>     to use more standard phraseology.
>
> compiler/optdb_help.m:
> compiler/print_help.m:
>     Define and implement some new semantic categories,
>     to help with the change to options.m.
>
> tests/warnings/help_text.err_exp:
>     Expect the updated help texts.


...


> diff --git a/tests/warnings/help_text.err_exp b/tests/warnings/help_text.err_exp
> index df3f56847..03d31599e 100644
> --- a/tests/warnings/help_text.err_exp
> +++ b/tests/warnings/help_text.err_exp
> @@ -642,20 +642,22 @@ Grade options
>  Options that control inference
>
>      --infer-all
> -        Abbreviation for `--infer-types --infer-modes --infer-det'.
> +        This option is an abbreviation for the combination of `--infer-types',
> +        `--infer-modes', and `--infer-det'.
>
>      --infer-types
>          If there is no type declaration for a predicate or function, try to
> -        infer the type, rather than just reporting an error.
> +        infer its type, rather than just reporting an error.


I suggest: s/rather than just/instead of/

Ditto elsewhere.

That looks fine otherwise.

Julien.


More information about the reviews mailing list