[m-rev.] for review: unravel_info

Julien Fischer jfischer at opturion.com
Thu Feb 20 16:19:43 AEDT 2025


On Thu, 20 Feb 2025 at 04:17, Zoltan Somogyi <zoltan.somogyi at runbox.com> wrote:

> Replace five pairs of state vars with one pair ...
>
> ... in the code that converts parse tree goals to HLDS goals.
>
> Putting those five data structures
>
> - the module_info,
> - the qual_info,
> - the varset of the predicate or function we are converting,
> - the non-position-dependent data needed by the state var transformation,
> - and the specs of the errors and warnings discovered so far
>
> into one structure simplifies a very large chunk of the parameter passing
> done in the modules of the make_hlds package. In most places, these structures
> were already passed around as a group, using the usual threading pattern
> for global state. (The position-dependent data used by the state var
> transformation has more complex threading patterns, and is therefore
> not included in the new grouped structure.) Several of the affected predicates
> have inline pragmas, which include the predicates' arities; in most cases,
> this diff changes their arity from 16 to 8.

That's fine.

Julien.


More information about the reviews mailing list