[m-rev.] for review: fix library installation with mmake and no symlinks

Zoltan Somogyi zoltan.somogyi at runbox.com
Mon Dec 29 11:54:25 AEDT 2025



On Mon, 29 Dec 2025 00:58:33 +1100, Julien Fischer <jfischer at opturion.com> wrote:
> I'm not sure if the proposed library method you were working on requires
> a similar fix.

I don't think it does, but I will have a look.

> +        "\t{ test -d $(INSTALL_INT_DIR)/Mercury/mhs || \\",
> +        "\t\t$(INSTALL_MKDIR) \\",
> +        "\t\t$(INSTALL_INT_DIR)/Mercury/mhs; \\",

The target directory should be either on the same line as mkdir command,
or, if it does not fit, it should be indented one more tab.

Other than that style niggle, the diff is fine.

Zoltan.




More information about the reviews mailing list