[m-rev.] for review: record_all_arguments

[Julien Fischer]

On Tue, 16 Dec 2025 at 18:06, Zoltan Somogyi <zoltan.somogyi at runbox.com>
wrote:

> For review by anyone. The diff does not include the automatically-updated
> getopt.m.
>
> I would like feedback on
>
> - whether we should change the argument order of record_arguments
>   to match the new record_all_arguments (I think we should, since it was
>   added after the last release), and
>

Yes.

- whether we should use the new functionality to let mmc continue
>   doing its job in the presence of bad options.
>

What do you mean by "continue doing its job"?  Presumably, we still
stop at some point and complain about the bad options?

> Add a mechanism for recording *all* command line args.

...

> diff --git a/NEWS.md b/NEWS.md
> index 777c9bbac..41349f35c 100644
> --- a/NEWS.md
> +++ b/NEWS.md
> @@ -1918,7 +1918,7 @@ Changes that may break compatibility
>  * We have renamed the `lexer` and `parser` modules of the Mercury
standard
>    library to `mercury_term_lexer` and `mercury_term_parser` respectively.
>
> -* We have made slight changes to the names and/or the functionality
> +* We have made slight changes to the names and/or to the functionality
>    of several predicates in the `getopt` and `getopt_io` modules.
>
>  * We have removed the legacy support for the Alpha architecture.
> @@ -2027,10 +2027,11 @@ Changes to the Mercury standard library
>
>  * The following new predicates have been added:
>
> +    - pred `record_all_arguments/7`
>      - pred `record_arguments/8`
>      - pred `expand_file_specials/8`
>
> -* The following variants of the existing process_options predicate
> +* The following variants of the existing `process_options` predicate
>    have been added:
>
>      - pred `process_options_io/6`
> @@ -2051,8 +2052,8 @@ Changes to the Mercury standard library
>      - pred `process_options/7`
>      - pred `process_options_track/7`
>
> -    All these predicates used to return error indications in the form of
a
> -    simple string. They now return error indications using the existing
> +    All these predicates used to return error indications in the form of
> +    a simple string. They now return error indications using the existing
>      structured type `option_error`, which can be converted into a string
>      on demand.

You have made these changes to the wrong section of the NEWS file.
This is the news for 22.01; your changes should be listed in the
news since 22.01 section.

(Perhaps we should move the 22.01 news into the HISTORY file now, rather
than waiting until just before the creation of the next release branch?)

That's fine otherwise.

Julien.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mercurylang.org/archives/reviews/attachments/20251216/e837e40c/attachment.html>