[m-rev.] for post-commit review: grade-and-architecture-specific extensions

[Julien Fischer]

On Wed, 18 Sept 2024 at 21:46, Zoltan Somogyi <zoltan.somogyi at runbox.com> wrote:

> Classify grade-specific files on architecture-specificity.

...

> diff --git a/compiler/file_names.m b/compiler/file_names.m
> index ce8c824df..85be63073 100644
> --- a/compiler/file_names.m
> +++ b/compiler/file_names.m

...

> @@ -193,11 +211,22 @@
>              % All extensions whose files can get put either into the current
>              % directory, or into a grade-specific subdirectory.
>
> +    ;       ext_cur_gas(ext_cur_gas)
> +            % All extensions whose files can get put either into the current
> +            % directory, or into a grade-and-architecture-specific
> +            % subdirectory.
> +
>      ;       ext_cur_ngs_gs(ext_cur_ngs_gs)
>              % All extensions whose files can get put either into the current
>              % directory, or into a non-grade-specific subdirectory, or into
>              % a grade-specific subdirectory, with search being irrelevant.
>
> +    ;       ext_cur_ngs_gas(ext_cur_ngs_gas)
> +            % All extensions whose files can get put either into the current
> +            % directory, or into a non-grade-specific subdirectory, or into
> +            % a grade-and-architecture-specific subdirectory,
> +            % with search being irrelevant.
> +
>      ;       ext_cur_ngs_gs_err(ext_cur_ngs_gs_err)
>              % Like the ext_cur_ngs_gs category, but whether or not .err files
>              % are placed in the current directory, or into a non-grade-specific
> @@ -312,6 +341,10 @@
>              % to classify them as effectively a non-grade-specific files.
>
>  :- type ext_cur_gs
> +    --->    ext_cur_gs_lib_init                 % ".init"
> +    ;       ext_cur_gs_lib_jar.                 % ".jar"

I assume you put .jar files in the _gs category, because Java byte code
is not architecture specific? However, the CIL byte code used in the.dll files
generated in the C# grade is similarly architecture independent, but they are
in the _gas category.  (I guess the issue is that Microsoft also use the .dll
extension for native code libraries as well.)

The diff looks fine otherwise.

Julien.